Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hds 2541 fix small console warnings #1449

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

timwessman
Copy link
Contributor

@timwessman timwessman commented Dec 12, 2024

Description

Fixed some warnings. I made separate commits on separate warning types I found and fixed.

Related Issue

Closes HDS-2541

How Has This Been Tested?

I opened all component pages on documentation and fixed console warnings. There shouldn't be any warnings of the fixed kind. There are still many other kinds of warnings, but this is a start.

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • Added needed line to changelog

Copy link

Test Results

  1 files   64 suites   11m 41s ⏱️
 60 tests  60 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit a15c45c.

Copy link

Preview found from hds-demo docs/preview_1449

Demos

Docs
Core Storybook
React Storybook

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NikoHelle
Copy link
Contributor

Huge "small" change. Good job!

@timwessman timwessman merged commit 73563b9 into development Dec 18, 2024
8 checks passed
@timwessman timwessman deleted the hds-2541-fix-small-console-warnings branch December 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants